Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master to features/covariant-returns #43577

Merged
400 commits merged into from
Apr 23, 2020
Merged

Merge master to features/covariant-returns #43577

400 commits merged into from
Apr 23, 2020

Conversation

gafter
Copy link
Member

@gafter gafter commented Apr 22, 2020

No description provided.

dpoeschl and others added 30 commits April 13, 2020 15:04
@dpoeschl
Remove unused code
94f180a
@CyrusNajmabadi
Move trycatch
0333eb9
@CyrusNajmabadi
Add notes
29ee056
@CyrusNajmabadi
Add notes
9902759
@dpoeschl
Update comment
6d4cb2c
@dpoeschl
Rid GetContentFromDocumentationCommentTriviaSyntax of ToArray calls
94f0cdd
@sharwell
Updated documentation for GetBestTypeByMetadataName
680673a
@sharwell
Merge remote-tracking branch 'dotnet/master' into regex-features
02db7d3
@sharwell
Add support for completion providers in NuGet packages
3e59efc 
Closes dotnet#30270
@sharwell
Add a timeout for InteractiveWindow.SubmitText
6e57238
@dpoeschl
Fix C# AddNameToArgument to support AttributeArguments
9eef708
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/master' into allowSymbolOOp3
5c7b1d5
@dpoeschl
Add test for VB Attributes with omitted arguments
9361919
@CyrusNajmabadi
Remove default hashing/equality
23a72b2
@dpoeschl
Rename CompensatingParameterConfigurations and add doc comment
e33fcef
@CyrusNajmabadi
Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.…
34b4273 
…CompilationTracker.State.cs
@dpoeschl
Dedupe some of IsParamsArrayExpanded
6de57b4
@dpoeschl
Remove unnecessary nullable !
911749b
@dpoeschl
Rename IsCallsiteError to IsCallsiteTodo and document Parameter prope…
498172d 
…rties
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/master' into dateTimeFormat
bfc05f0
@sharwell
Document and validate arguments for RemoveOrTransformAll
c12fec0
@sharwell
Add a timeout for Editor.WaitForActiveView
4c692c4
@CyrusNajmabadi
Tests
f34c527
@sharwell
Update Xunit.Combinatorial to 1.3.2
2792d31
@dpoeschl
Use SetProperty from AbstractNotifyPropertyChanged
55bb204
@dpoeschl
PR Feedback
d393266
@dpoeschl
Correctly resize AddParameter (the type input box grows)
fcacb78
@dpoeschl
Put tests in the right files.
d69f0a4
@dpoeschl
Remove irrelevant comments
c742517
@sharwell
Remove IterationDataAttribute
2a3840e 
This attribute has been superseded by CombinatorialRangeAttribute.
CyrusNajmabadi and others added 17 commits April 21, 2020 18:41
@CyrusNajmabadi
Support OOP with dynamic types.
e90cf29
@CyrusNajmabadi
Add support for cref-type-parameters.
2cdfd45
@jmarolf
Merge pull request dotnet#43539 from jmarolf/infra/always-partition-t…
50d0e54 
…ests

always partition tests assemblies
@jcouv
Fix GetSymbolInfo on ValueTuple declaration (dotnet#43467)
df5bbbc
@CyrusNajmabadi
Merge pull request dotnet#43492 from CyrusNajmabadi/orWideningCastCheck
8f4fdad 
Do not offer to remove cast if it will cause the compiler to warn about it.
@CyrusNajmabadi
Rename methods
1dee068
@CyrusNajmabadi
Push options down.
a7ed207
@CyrusNajmabadi
use capacity when creating builders.
2c3af48
@zaytsev-victor
PR feedback
6952136
@zaytsev-victor @CyrusNajmabadi
Update src/Analyzers/Core/CodeFixes/MakeFieldReadonly/AbstractMakeFie…
4d3e5d3 
…ldReadonlyCodeFixProvider.cs

Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/master' into findRefsCollapsing
f023226
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/master' into renameOOP4
7258527
@CyrusNajmabadi
Fix
6bf71e1
Merge pull request dotnet#43554 from CyrusNajmabadi/renameOOP4
a1b8670 
Move the 'finding' portoin of rename out of process.
@CyrusNajmabadi
Merge pull request dotnet#43542 from zaytsev-victor/Fixed42759
d99f93a 
Fixed MakeFieldReadonlyCodeFixProvider for volatile fields.
Merge pull request dotnet#43472 from CyrusNajmabadi/findRefsCollapsing
27aab41 
Ensure the initial symbol a user searches for is top of hte find-refs list
Merge branch 'master' of https://github.com/dotnet/roslyn into covari…
723440c 
…ant-returns-merge-2020-04-22
@gafter gafter requested review from a team as code owners April 22, 2020 22:47
@gafter gafter self-assigned this Apr 22, 2020
ghost
ghost approved these changes Apr 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@gafter gafter added the Feature - Covariant Returns Permit an override to return a more specific reference type label Apr 22, 2020
@gafter gafter added this to the Compiler.Net5 milestone Apr 22, 2020
@ghost ghost merged commit e14df2f into dotnet:features/covariant-returns Apr 23, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@gafter gafter

Labels
Area-Compilers auto-merge Feature - Covariant Returns Permit an override to return a more specific reference type
Projects
None yet
Milestone
Compiler.Net5
Development

Successfully merging this pull request may close these issues.