Support a single OOP call to perform all of rename, on top of the individual pieces of rename that are already OOPed #43593
Conversation
|
@ryzngard This is ready for review. Thanks! |
| @@ -55,7 +56,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.Rename | |||
| workspace.SetTestLogger(AddressOf helper.WriteLine) | |||
|
|
|||
| workspace.TryApplyChanges(workspace.CurrentSolution.WithOptions( | |||
| workspace.Options.WithChangedOption(RemoteHostOptions.RemoteHostTest, host = TestHost.OutOfProcess))) | |||
| workspace.Options.WithChangedOption(RemoteHostOptions.RemoteHostTest, host <> TestHost.InProcess))) | |||
There was a problem hiding this comment.
@ryzngard This is an example of what i was talking about earllier. We want OOP enabled for all optoins that are not 'InProcess'.
There was a problem hiding this comment.
Not sure I follow. Are there multiple OutOfProcess values? It seems like you're basically comparing value != false instead of value == true (ignoring that value could just be the argument here...)
There was a problem hiding this comment.
Reading further now I get it
Public Enum TestHost
InProcess InProcess
OutOfProcess ' Work out of process, marshaling to/from RenameSymbolAsync
OutOfProcess_SingleCall
' Work out of process, marshaling to/from FindRenameLocations, then marshaling to/from ResolveConflictsAsync
OutOfProcess_SplitCall
End Enum End Enum
There are multiple out of process hosts. That's the missing bit :)
CyrusNajmabadi
changed the title
| @@ -55,7 +56,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.Rename | |||
| workspace.SetTestLogger(AddressOf helper.WriteLine) | |||
|
|
|||
| workspace.TryApplyChanges(workspace.CurrentSolution.WithOptions( | |||
| workspace.Options.WithChangedOption(RemoteHostOptions.RemoteHostTest, host = TestHost.OutOfProcess))) | |||
| workspace.Options.WithChangedOption(RemoteHostOptions.RemoteHostTest, host <> TestHost.InProcess))) | |||
There was a problem hiding this comment.
Not sure I follow. Are there multiple OutOfProcess values? It seems like you're basically comparing value != false instead of value == true (ignoring that value could just be the argument here...)
| @@ -55,7 +56,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.Rename | |||
| workspace.SetTestLogger(AddressOf helper.WriteLine) | |||
|
|
|||
| workspace.TryApplyChanges(workspace.CurrentSolution.WithOptions( | |||
| workspace.Options.WithChangedOption(RemoteHostOptions.RemoteHostTest, host = TestHost.OutOfProcess))) | |||
| workspace.Options.WithChangedOption(RemoteHostOptions.RemoteHostTest, host <> TestHost.InProcess))) | |||
There was a problem hiding this comment.
Reading further now I get it
Public Enum TestHost
InProcess InProcess
OutOfProcess ' Work out of process, marshaling to/from RenameSymbolAsync
OutOfProcess_SingleCall
' Work out of process, marshaling to/from FindRenameLocations, then marshaling to/from ResolveConflictsAsync
OutOfProcess_SplitCall
End Enum End Enum
There are multiple out of process hosts. That's the missing bit :)
|
Thanks! |
ghost
added this to the 
Followup to #43592. That PR should go in first.This also adds OOP tests for direct calls to rename, as well as OOP calling the individual parts of rename