Correctly use JoinableTaskCollection #45848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was incorrectly using JoinableTaskCollection.Join() under the impression that it actually did the wait; instead it just grants the ability for any of the JoinableTasks in the collection to use the current thread you're on, but doesn't actually do any waiting. This replaces it with the correct behavior.
dibarbet
approved these changes
Jul 9, 2020
davidwengier
approved these changes
Jul 9, 2020
|
This is likely superseded by #45850 |
|
Indeed, I'll close this when that goes in. |
|
Superseded by #45850. |
jasonmalinowski
deleted the
fix-incorrect-use-of-joinabletaskcollection.join
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was incorrectly using JoinableTaskCollection.Join() under the impression that it actually did the wait; instead it just grants the ability for any of the JoinableTasks in the collection to use the current thread you're on, but doesn't actually do any waiting. This replaces it with the correct behavior.