Improve the "not exhaustive" diagnostic in the presence of a when clause. #46143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
Concept-Diagnostic Clarity
|
@alrz This is based on your suggestion. |
|
@dotnet/roslyn-compiler May I please have a couple of reviews of this diagnostic improvement? |
1 similar comment
|
@dotnet/roslyn-compiler May I please have a couple of reviews of this diagnostic improvement? |
RikkiGibson
approved these changes
Jul 22, 2020
|
@dotnet/roslyn-compiler May I please have a second review? |
2 similar comments
|
@dotnet/roslyn-compiler May I please have a second review? |
|
@dotnet/roslyn-compiler May I please have a second review? |
cston
reviewed
Jul 29, 2020
| @@ -22,23 +22,26 @@ internal static class PatternExplainer | |||
| /// <param name="nodes">The set of nodes in topological order.</param> | |||
| /// <param name="node">The node of interest.</param> | |||
| /// <param name="nullPaths">Whether to permit following paths that test for null.</param> | |||
| /// <param name="requiresFalseWhenClause">set to true when if the path requires some when clause to evaluate to 'false'</param> | |||
There was a problem hiding this comment.
when if [](start = 62, length = 7)
Typo?
cston
approved these changes
Jul 29, 2020
|
Hello @gafter! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
modified the milestones:
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 31, 2020
* upstream/master: (304 commits) Tweak diagnostics to account for records (dotnet#46341) Diagnose precedence inversion in a warning wave (dotnet#46239) Remove PROTOTYPE tag (dotnet#45965) Only run a single pass of NullableWalker per-member (dotnet#46402) Fix crash, and offer "declare as nullable" for tuple fields (dotnet#46437) Simplify contract for RunWithShutdownBlockAsync Fix optprof plugin input check if EditorAdaptersFactoryService gives us a null buffer Cannot assign maybe-null value to TNotNull variable (dotnet#41445) Fix overload resolution to handle binary compat in the face of covariant returns (dotnet#46367) Same failure on Linux Skip some tests on Mac Added search option for inline parameter name hints Spelling tweak docs Improve comment Improve the "not exhaustive" diagnostic in the presence of a when clause. (dotnet#46143) PR feedback Use record keyword to display records (dotnet#46338) remove test that aserts .NET Standard should be prefered over .NET Framework ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45157