Check in simple end-to-end test for covariant returns. #46285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
Feature - Covariant Returns
|
/cc @jaredpar |
Add a canary test that fails on a runtime supporting covaraint returns to make sure we're testing CI
jaredpar
approved these changes
Jul 24, 2020
jcouv
reviewed
Jul 24, 2020
| @@ -4,7 +4,7 @@ | |||
| <PropertyGroup> | |||
| <OutputType>Library</OutputType> | |||
| <RootNamespace>Microsoft.CodeAnalysis.CSharp.UnitTests</RootNamespace> | |||
| <TargetFrameworks>netcoreapp3.1;net472</TargetFrameworks> | |||
| <TargetFrameworks>net5.0;net472</TargetFrameworks> | |||
There was a problem hiding this comment.
Just to confirm, we're intentionally keeping our other test projects targeting netcoreapp3.1? #Resolved
jcouv
reviewed
Jul 24, 2020
|
|
||
| static CovariantReturnTests() | ||
| { | ||
| if (new CovarantReturnRuntimeOnly().ShouldSkip) |
There was a problem hiding this comment.
CovarantReturnRuntimeOnly [](start = 20, length = 25)
typo: Covariant
…t/roslyn into covariant-returns-e2e1
…hat is what is breaking the tests.
This updates our build to support the use of `net5.0` as a target framework inside of our repository. Note: this is back porting some changes from the covariant returns branch. Wanted to get them into master sooner so we get more exposure to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.