Remove feature flag used for testing "DoNotRequireRuntimeCovariantReturnsSupport" #46390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
Feature - Covariant Returns
jcouv
reviewed
Jul 29, 2020
| @@ -428,28 +428,14 @@ internal bool RuntimeSupportsDefaultInterfaceImplementation | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Figure out if the target runtime supports covariant returns of methods declared in classes. | |||
| /// True if the target runtime support covariant returns of methods declared in classes. | |||
|
Taking a look |
RikkiGibson
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44206
This also tests the runtime behavior of code generated by the VB compiler that interacts with C# covariant methods.