Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate DiagnosticAnalyzerService from DiagnosticTaggerWrapper #46521

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Remove duplicate DiagnosticAnalyzerService from DiagnosticTaggerWrapper #46521

merged 2 commits into from
Aug 4, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Aug 3, 2020 •
edited
Loading

Fixes #46463

@sharwell sharwell requested review from a team as code owners August 3, 2020 19:49
@tmat
Copy link
Member

tmat commented Aug 3, 2020

@mavasani FYI

@mavasani
Copy link
Contributor

mavasani commented Aug 3, 2020

Thanks, I was going to investigate it today :-). I have moved the issue to Sam.

@sharwell sharwell merged commit 204ab0c into dotnet:master Aug 4, 2020
@ghost ghost added this to the Next milestone Aug 4, 2020
@sharwell sharwell deleted the squiggles branch August 4, 2020 15:32
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
@sharwell sharwell mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.8.P2
Development

Successfully merging this pull request may close these issues.

DiagnosticService reports duplicate diagnostics
4 participants
@sharwell @tmat @mavasani @RikkiGibson