Move to .NET 5 Preview 8 SDK #47165

333fred · 2020-08-26T21:46:17Z

Moves us to .NET 5 Preview 8, including the P8 SCI and SRM binaries.

333fred · 2020-08-26T21:47:34Z

@dotnet/roslyn-infrastructure please take a look.

I had to create a separate draft PR with this change based on master-vs-deps, as the line above the SCI/SRM binary versions was changed, causing a merge conflict. The draft is here:
#47166

I've kicked off a signed build for a test insertion:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4014805&view=results

Test insertion:
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/270509

333fred · 2020-08-26T21:48:27Z

eng/Versions.props

@@ -243,8 +243,8 @@
    -->
    <NewtonsoftJsonVersion>12.0.2</NewtonsoftJsonVersion>
    <StreamJsonRpcVersion>2.4.34</StreamJsonRpcVersion>
-    <SystemCollectionsImmutableVersion>5.0.0-preview.8.20371.14</SystemCollectionsImmutableVersion>
-    <SystemReflectionMetadataVersion>5.0.0-preview.8.20371.14</SystemReflectionMetadataVersion>
+    <SystemCollectionsImmutableVersion>5.0.0-preview.8.20407.11</SystemCollectionsImmutableVersion>


These are the public versions available on NuGet.

sharwell · 2020-08-26T22:26:14Z

global.json

    "allowPrerelease": true,
    "rollForward": "major"
  },
  "tools": {
-    "dotnet": "5.0.100-preview.7.20366.6",
+    "dotnet": "5.0.100-preview.8.20417.9",
    "vs": {
      "version": "16.6"


❔ This needs an update as well right?

Yeah, probably. I just want to see the CI work first :)

jaredpar · 2020-08-26T22:39:27Z

FYI: this will mean that we need to move our minimum Visual Studio version to 16.8 preview as well. The Net5 P8 SDK depends on having 16.8 MSBuild hence in order to develop roslyn after this change you will need 16.8 preview on your machine.

I don't say this is a blocker, just as an FYI. It's been known for a while at a division level most of our repos would need to move to a preview VS for the end game of .NET5. We should tell the team though.

jasonmalinowski · 2020-08-26T22:44:10Z

docs/contributing/Building, Debugging, and Testing on Windows.md

@@ -20,7 +20,7 @@ The minimal required version of .NET Framework is 4.7.2.
    - Ensure Visual Studio is on Version "16.5" or greater
    - Ensure "Use previews of the .NET Core SDK" is checked in Tools -> Options -> Environment -> Preview Features
    - Restart Visual Studio
-1. [.NET Core SDK 5.0 Preview 7](https://dotnet.microsoft.com/download/dotnet-core/5.0) [Windows x64 installer](https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-5.0.100-preview.7-windows-x64-installer)
+1. [.NET Core SDK 5.0 Preview 8](https://dotnet.microsoft.com/download/dotnet-core/5.0) [Windows x64 installer](https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-5.0.100-preview.8-windows-x64-installer)


Per @jaredpar's comments, this also bumps us to requiring 16.8 -- do we need to update line 18 accordingly?

💡 If we update the solution file appropriately, earlier versions of VS will actually know to report an error if you try to open it.

roslyn/Roslyn.sln

Line 4 in 255cb1e

MinimumVisualStudioVersion = 10.0.40219.1

333fred · 2020-08-27T00:19:34Z

I have validated building, testing, and F5'ing Roslyn.sln with 16.8p2. All seems to be working.

global.json

(cherry picked from commit 59423b8)

333fred · 2020-09-02T22:59:30Z

I'm breaking the SCI and SRM updates out of this PR and into #47397 to unblock partner teams.

333fred · 2020-09-03T18:08:41Z

@sharwell or @JoeRobich can you please look into the integration test failures? Feel free to push to this branch.

JoeRobich · 2020-09-03T20:34:17Z

hmm

333fred · 2020-09-09T16:03:22Z

@JoeRobich or @sharwell, any progress here?

333fred · 2020-09-10T17:49:30Z

/azp run

azure-pipelines · 2020-09-10T17:49:44Z

Azure Pipelines successfully started running 2 pipeline(s).

333fred · 2020-09-15T01:06:32Z

I attempted to run the coreclr tests locally to figure out what is hanging. I wasn't able to see a hang locally, but I did see multiple test breakages from dotnet/runtime#42234.

jasonmalinowski

Signing off to unblock the work, but please make sure the queue change to the integration test runs are rolled back as soon as practicable.

jasonmalinowski · 2020-09-18T19:02:50Z

azure-pipelines-integration.yml

@@ -18,22 +18,23 @@ jobs:
 - job: VS_Integration
  pool:
    name: NetCorePublic-Pool
-    queue: buildpool.windows.10.amd64.vs2019.pre.open
+    queue: buildpool.windows.vs2019.pre.scouting.open


Do we still need this or is the Preview 2 queue now the main queue? We don't want to be permanently on the scouting queue or else we'd be get broken the moment it's updated.

(fine to merge in this state if it's necessary but please fix ASAP as otherwise this is setting a trap to break things)

Preview2 is the main queue now, which is coincidentally why the integration tests aren't quite working
https://github.com/dotnet/core-eng/wiki/VS2019-Upgrade-Schedule

Moved back to the main pool.

ghost · 2020-09-18T21:53:09Z

Hello @333fred!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost

Auto-approval

sharwell · 2020-09-19T20:37:28Z

azure-pipelines-integration.yml

+      # 64-bit disabled for https://github.com/dotnet/roslyn/issues/40476
+      # debug_64:
+      #   _configuration: Debug
+      #   _oop64bit: true


😨 These are our only tests for OOP.

64-bit testing covers the 99.9% customer scenario.

@tmat and @jasonmalinowski confirmed that we were not introducing any new product bugs here, only exposing existing issues. Given that this was also blocking other work, we opted to not hold this PR hostage to existing bugs that cannot be fixed at the same time.

And in parallel with that analysis, an image upgrade to our machine pool also meant the builds were entirely broken for integration tests unless we merged this PR to upgrade to Preview 8. (The SDK on the image upgraded and a version compat bug meant the mismatch broke builds.) So this quickly went from something we were doing with regret to something we had no alternative for.

The integration tests were working in this pull request as of afbbec1 (10 September). I've requested this be treated as proof of a ship-blocking product regression introduced either by this change, or in parallel with this change, until we can figure the reason why they stopped working again. The fix(es) I find over the remainder of the weekend will be added to #47870.

333fred requested a review from a team as a code owner August 26, 2020 21:46

333fred commented Aug 26, 2020

View reviewed changes

sharwell reviewed Aug 26, 2020

View reviewed changes

sharwell changed the title ~~Move to P8~~ Move to .NET 5 Preview 8 SDK Aug 26, 2020

jasonmalinowski reviewed Aug 26, 2020

View reviewed changes

333fred commented Aug 27, 2020

View reviewed changes

global.json Outdated Show resolved Hide resolved

jmarolf mentioned this pull request Aug 28, 2020

use latest sdk dotnet/roslyn-analyzers#4080

Merged

333fred added 5 commits September 2, 2020 10:37

Move to .NET 5p8.

197d680

Update RoslynTools.MSBuild version.

7fb64b2

(cherry picked from commit 59423b8)

Ensure that 16.8p2 is the minimum documented version.

4093e09

Require 16.9 to force build machines to have the latest VS previews.

df896ae

Depend on vs 16.8p2

79756ab

333fred force-pushed the p8 branch from 1065207 to 79756ab Compare September 2, 2020 17:39

333fred added 3 commits September 2, 2020 11:14

Use just 16.8

2e3fe6a

Move to the VS scouting pool.

b020e79

Temp troubleshooting.

4857bab

Update intellisense command.

198eaf5

333fred requested a review from a team as a code owner September 3, 2020 01:44

jmarolf mentioned this pull request Sep 4, 2020

use static graph to reduce restore times #43233

Merged

JoeRobich closed this Sep 9, 2020

JoeRobich reopened this Sep 9, 2020

sharwell and others added 3 commits September 10, 2020 13:55

Improve messaging for integration test failures

ed07df5

Mark methods static to avoid new CA1822 reports in .NET 5 Preview 8

afbbec1

Merge branch 'master' into p8

6965a13

333fred requested a review from a team as a code owner September 15, 2020 01:18

333fred force-pushed the p8 branch from c62f218 to 6965a13 Compare September 15, 2020 17:58

Retarget interactive host to net50

400f5ec

333fred requested a review from a team as a code owner September 16, 2020 23:02

tmat and others added 2 commits September 16, 2020 16:06

Use net5.0

cfb9177

Skip failing interactive test.

ee8a29e

jasonmalinowski assigned jasonmalinowski and 333fred Sep 17, 2020

jmarolf approved these changes Sep 18, 2020

View reviewed changes

Disable 64-bit integration tests. Tracked by dotnet#40476.

e6a0bb1

jaredpar approved these changes Sep 18, 2020

View reviewed changes

jasonmalinowski approved these changes Sep 18, 2020

View reviewed changes

Move to the regular preview buildpool.

d8d8778

333fred force-pushed the p8 branch from 7bc76a2 to d8d8778 Compare September 18, 2020 19:27

333fred added the auto-merge label Sep 18, 2020

ghost approved these changes Sep 18, 2020

View reviewed changes

jasonmalinowski merged commit 7a36f74 into dotnet:master Sep 18, 2020

ghost added this to the Next milestone Sep 18, 2020

333fred deleted the p8 branch September 18, 2020 21:59

sharwell reviewed Sep 19, 2020

View reviewed changes

runfoapplocaldev bot mentioned this pull request Sep 21, 2020

Temporary title jaredpar/runfo#24

Closed

dibarbet modified the milestones: Next, 16.8.P4 Sep 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to .NET 5 Preview 8 SDK #47165

Move to .NET 5 Preview 8 SDK #47165

333fred commented Aug 26, 2020

333fred commented Aug 26, 2020 •

edited

Loading

333fred Aug 26, 2020

sharwell Aug 26, 2020

333fred Aug 26, 2020

jaredpar commented Aug 26, 2020

jasonmalinowski Aug 26, 2020

sharwell Aug 26, 2020

333fred commented Aug 27, 2020

333fred commented Sep 2, 2020

333fred commented Sep 3, 2020

JoeRobich commented Sep 3, 2020 •

edited

Loading

333fred commented Sep 9, 2020

333fred commented Sep 10, 2020

azure-pipelines bot commented Sep 10, 2020

333fred commented Sep 15, 2020

jasonmalinowski left a comment

jasonmalinowski Sep 18, 2020

jasonmalinowski Sep 18, 2020

dibarbet Sep 18, 2020

333fred Sep 18, 2020

ghost commented Sep 18, 2020

ghost left a comment

sharwell Sep 19, 2020

sharwell Sep 19, 2020

333fred Sep 19, 2020

jasonmalinowski Sep 20, 2020 •

edited

Loading

sharwell Sep 20, 2020 •

edited

Loading

Move to .NET 5 Preview 8 SDK #47165

Move to .NET 5 Preview 8 SDK #47165

Conversation

333fred commented Aug 26, 2020

333fred commented Aug 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaredpar commented Aug 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

333fred commented Aug 27, 2020

333fred commented Sep 2, 2020

333fred commented Sep 3, 2020

JoeRobich commented Sep 3, 2020 • edited Loading

333fred commented Sep 9, 2020

333fred commented Sep 10, 2020

azure-pipelines bot commented Sep 10, 2020

333fred commented Sep 15, 2020

jasonmalinowski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Sep 18, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasonmalinowski Sep 20, 2020 • edited Loading

Choose a reason for hiding this comment

sharwell Sep 20, 2020 • edited Loading

Choose a reason for hiding this comment

333fred commented Aug 26, 2020 •

edited

Loading

JoeRobich commented Sep 3, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

jasonmalinowski Sep 20, 2020 •

edited

Loading

sharwell Sep 20, 2020 •

edited

Loading