Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark APIs as shipped #48059

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Mark APIs as shipped #48059

merged 1 commit into from
Sep 29, 2020

Conversation

333fred
Copy link
Member

@333fred 333fred commented Sep 25, 2020

Mark all APIs as shipped for the 16.8 release.

@333fred
Mark APIs as shipped
9f50f82 
Mark all APIs as shipped for the 16.8 release.
@333fred 333fred requested review from a team as code owners September 25, 2020 20:26
@333fred 333fred changed the base branch from master to release/dev16.8 September 25, 2020 20:27
@333fred
Copy link
Member Author

333fred commented Sep 25, 2020

@dotnet/roslyn-compiler @dotnet/roslyn-ide for review please.

sharwell
sharwell approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE changes seem fine

@RikkiGibson RikkiGibson self-assigned this Sep 25, 2020
RikkiGibson
RikkiGibson approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on changes under src/Compilers

src/Compilers/CSharp/Portable/PublicAPI.Shipped.txt Show resolved Hide resolved
src/Compilers/CSharp/Portable/PublicAPI.Shipped.txt Show resolved Hide resolved
This was referenced Sep 25, 2020
Closed
Closed
Closed
@RikkiGibson RikkiGibson mentioned this pull request Sep 25, 2020
Open
@333fred
Copy link
Member Author

333fred commented Sep 25, 2020

@dotnet/roslyn-compiler for a second review.

@333fred
Copy link
Member Author

333fred commented Sep 28, 2020

@dotnet/roslyn-compiler for a second review here please.

AlekseyTs
AlekseyTs approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@333fred 333fred merged commit d77f160 into dotnet:release/dev16.8 Sep 29, 2020
@333fred 333fred deleted the ship-apis branch September 29, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@sharwell sharwell sharwell approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@333fred @sharwell @RikkiGibson @AlekseyTs