Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deterministic metadata names for emitted anonymous type fields. #49370

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Use deterministic metadata names for emitted anonymous type fields. #49370

merged 1 commit into from
Nov 16, 2020

Conversation

AlekseyTs
Copy link
Contributor

Fixes #48417.

@AlekseyTs AlekseyTs requested a review from a team as a code owner November 14, 2020 00:53
@jcouv jcouv added the Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. label Nov 14, 2020
jcouv
jcouv approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@Youssef1313
Copy link
Member

A tracking issue to revert 9796485 may be needed.

@AlekseyTs AlekseyTs merged commit a967b49 into dotnet:master Nov 16, 2020
@ghost ghost added this to the Next milestone Nov 16, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 16, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merge-master
037c07d 
* upstream/master: (148 commits)
  Remove unnecessary ArrayBuilder in MakeCallWithNoExplicitArgument (dotnet#49377)
  Revert "Skip binary for determinism checking"
  Use deterministic metadata names for emitted anonymous type fields. (dotnet#49370)
  Reuse LSP solutions if they don't need re-forking (dotnet#49305)
  Small nullability fixes (dotnet#49279)
  Create default arguments during binding (dotnet#49186)
  Clean nits
  Backport dotnet#48420 to release/dev16.8 (dotnet#49357)
  Rewrite AnalyzeFileReference.GetSupportedLanguages without LINQ (dotnet#49337)
  Use .Any extension of ImmutableArray(Of Symbol) (dotnet#48980)
  fix 'remove unnecessary cast' when doing bitwise ops on unsigned values.
  Harden, document, cross-link XunitDisposeHook
  Simplify x86 hook
  Fix split comment exporting for VB.
  Code style fix
  Overwrite xunit's app domain handling to not call AppDomain.Unload
  Revert pragma suppression
  Remove blank line
  Revert file
  Move block structure code back to Features layer
  ...
@Youssef1313 Youssef1313 mentioned this pull request Nov 19, 2020
Merged
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees
No one assigned
Labels
Area-Compilers Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time.
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.

VB has non-deterministic output when anonymous types differ in case
5 participants
@AlekseyTs @Youssef1313 @RikkiGibson @jcouv @allisonchou