Hot Reload watch service #51967
Merged
Hot Reload watch service #51967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
WatchExternalAccess
branch
from
baa123c
to
48b5a09
Compare
tmat
force-pushed
the
WatchExternalAccess
branch
from
48b5a09
to
8a03b63
Compare
|
Did you miss adding |
|
@pranavkm Ah, yes. Sadly |
pranavkm
reviewed
Mar 19, 2021
src/EditorFeatures/TestUtilities/EditAndContinue/MockEditAndContinueWorkspaceService.cs
Show resolved
Hide resolved
pranavkm
reviewed
Mar 19, 2021
src/Features/Core/Portable/ExternalAccess/Watch/Api/WatchHotReloadService.cs
Outdated
Show resolved
Hide resolved
pranavkm
approved these changes
Mar 19, 2021
davidwengier
approved these changes
Mar 21, 2021
ghost
added this to the 
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
WatchHotReloadServicewrapper aroundIEditAndContinueWorkspaceServicethat exposes EnC functionality in a shape suitable for dotnet watch.Adds new capability to
StartDebuggingSessionAsyncthat allows the EnC service to hydrate the content of files that support EnC in the given solution snapshot and checks that the sources match the checksums stored in the PDB. Matching document ids are cached so that the validation does not need to be redone when emitting deltas later on.Implements #50773