Run the MSBuildWorkspace tests on .Net Core #52064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Mar 23, 2021
src/Workspaces/MSBuildTest/VisualStudioMSBuildWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/MSBuildTest/DotNetSdkMSBuildInstalled.LooseAssemblyVersionLoader.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/MSBuildTest/DotNetSdkMSBuildInstalled.LooseAssemblyVersionLoader.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/MSBuildTest/DotNetSdkMSBuildInstalled.LooseAssemblyVersionLoader.cs
Outdated
Show resolved
Hide resolved
Comment on lines
-17
to
-20
| [DllImport("Microsoft.VisualStudio.Setup.Configuration.Native.dll", ExactSpelling = true, PreserveSig = true)] | ||
| private static extern int GetSetupConfiguration( | ||
| [MarshalAs(UnmanagedType.Interface), Out] out ISetupConfiguration configuration, | ||
| IntPtr reserved); |
There was a problem hiding this comment.
I am very happy to see this going away!
src/Workspaces/MSBuildTest/VisualStudioMSBuildWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| [ConditionalFact(typeof(VisualStudioMSBuildInstalled)), Trait(Traits.Feature, Traits.Features.MSBuildWorkspace)] | ||
| public async Task TestOpenProject_WithXaml() |
There was a problem hiding this comment.
Can this run on .NET 5, at least with some variations?
There was a problem hiding this comment.
I've tried adding a test for this and the generated source files do not get added to the workspace. The compilation contains the following diagnostic.
error CS5001: Program does not contain a static 'Main' method suitable for an entry point
Perhaps the WPF on .NET core requires a particular target to be run...
There was a problem hiding this comment.
This is what documentation says about migrating. Note the different outputtype, tfm, and Microsoft.Windows.Compatibility reference (not sure if that's needed)
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net5.0-windows</TargetFramework>
<OutputType>WinExe</OutputType>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<UseWPF>true</UseWPF>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
<PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.2.211942">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.Windows.Compatibility" Version="5.0.2" />
</ItemGroup>
</Project>
jaredpar
reviewed
Mar 28, 2021
src/Workspaces/MSBuildTest/DotNetSdkMSBuildInstalled.LooseAssemblyVersionLoader.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This PR superseded by #57613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.