Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing [Fact] in ConversionCompletionProviderTests #52071

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Add missing [Fact] in ConversionCompletionProviderTests #52071

merged 1 commit into from
Mar 23, 2021

Conversation

MaStr11
Copy link
Contributor

@MaStr11 MaStr11 commented Mar 23, 2021

Follow up to #47511

I missed placing the [Fact] attribute on one test method.

CC @CyrusNajmabadi

@MaStr11
Add missing [Fact] in ConversionCompletionProviderTests
1b56a44 
Follow up to dotnet#47511

I missed placing the `[Fact]` attribute on one test method. @CyrusNajmabadi
@MaStr11 MaStr11 requested a review from a team as a code owner March 23, 2021 08:00
@Youssef1313
Copy link
Member

Youssef1313 commented Mar 23, 2021 •
edited
Loading

@sharwell You had a PR to add some missing [Fact]s (ccd35fa), it doesn't seem to include this one. Si there is a room that there are still more.

Wondering if you manually found the ones in your PRs or you wrote some analyzer?

@MaStr11
Copy link
Contributor Author

MaStr11 commented Mar 23, 2021

The test with the missing attribute got merged into main just 3 days ago. That was after @sharwell 's commit. I have found the missing attribute manually.

@sharwell sharwell merged commit 14cdeb2 into dotnet:main Mar 23, 2021
@ghost ghost added this to the Next milestone Mar 23, 2021
@MaStr11 MaStr11 deleted the patch-2 branch March 23, 2021 18:05
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
16.10.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@MaStr11 @Youssef1313 @sharwell @allisonchou