Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to features/improved-definite-assignment #53084

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from main into features/improved-definite-assignment.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/main-to-features/improved-definite-assignment
git reset --hard upstream/features/improved-definite-assignment
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-features/improved-definite-assignment --force

akhera99 and others added 30 commits April 9, 2021 16:06
…enu and the trampoline only adds parameters that are relevant to the expression
tmat and others added 19 commits April 29, 2021 12:10
Prepend first statement of using block with a newline, if opening bracket is on same line as using statement
It doesn't seem to be used anymore after #51815
Fix caret placement for argument completion snippets
Run LSP integration on rolling builds only until they're stable
Add ServiceHub implementation of IDocumentTrackingService
Catch exceptions within LazyToolTip
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit fbac2e0 into features/improved-definite-assignment May 2, 2021
@ghost ghost deleted the merges/main-to-features/improved-definite-assignment branch May 2, 2021 08:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.