Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VS16.10 the minimum required VS for builds #54997

Merged
36 commits merged into from
Jul 28, 2021
Merged

Make VS16.10 the minimum required VS for builds #54997

36 commits merged into from
Jul 28, 2021

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jul 20, 2021 •
edited
Loading

dotnet-maestro bot and others added 26 commits June 5, 2021 12:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
b4d0211 
…604.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21304.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
9a06c7f 
…611.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21311.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
f275211 
…614.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21314.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
38efc45 
…616.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21316.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
ca103c4 
…617.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21317.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
b5db981 
…618.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21318.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
ed5bc46 
…619.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21319.2
@JoeRobich
Leave SDK on .NET 6 Preview 3
6ec36c6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
0b172c4 
…621.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21321.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
73e296d 
…621.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21321.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
7fa7f8c 
…623.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21323.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
9b7e608 
…624.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21324.3
@JoeRobich
Leave SDK on NET 6 Preview 3
59554fa
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
87644e9 
…628.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21328.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
9cc3e25 
…629.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21329.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
27f6eb7 
…630.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21330.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
6aed397 
…701.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21351.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
132ef55 
…705.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21355.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
b944126 
…707.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21357.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
7da7f29 
…709.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21359.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
c62de2b 
…713.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21363.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
8c72db0 
…714.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21364.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
5d37472 
…715.11

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21365.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
5303bbf 
…716.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21366.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
7978ada 
…719.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21369.3
@JoeRobich
Make VS16.10 the minimum required VS for builds
143cf13
@JoeRobich JoeRobich mentioned this pull request Jul 20, 2021
Closed
JoeRobich and others added 2 commits July 20, 2021 16:59
@JoeRobich
Bump MSBuild.StructuredLogger to 2.1.500
f4a82e7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
5e0cb4b 
…720.12

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21370.12
@JoeRobich JoeRobich force-pushed the build-with-vs2019 branch from ed67d68 to 2d236f6 Compare July 22, 2021 22:38
@JoeRobich JoeRobich force-pushed the build-with-vs2019 branch from 2d236f6 to c03a724 Compare July 22, 2021 23:49
@JoeRobich JoeRobich marked this pull request as ready for review July 22, 2021 23:51
@JoeRobich JoeRobich requested a review from a team as a code owner July 22, 2021 23:51
This was referenced Jul 23, 2021
Closed
Closed
dotnet-maestro bot and others added 3 commits July 24, 2021 12:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
2d8ba86 
…723.11

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21373.11
@JoeRobich
Merge commit '2d8ba867cee767883ece5ac6c67d05e11330e7cc' into build-wi…
4265db9 
…th-vs2019
@JoeRobich
Update contributing docs
701c2b9
@RikkiGibson RikkiGibson self-assigned this Jul 27, 2021
RikkiGibson
RikkiGibson reviewed Jul 27, 2021
View reviewed changes
eng/test-determinism.ps1
@@ -21,7 +21,7 @@ if ($help) {
}

# List of binary names that should be skipped because they have a known issue that
# makes them non-deterministic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider trimming whitespace only on changed lines in the future.

ghost
ghost approved these changes Jul 28, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 8a90df2 into dotnet:main Jul 28, 2021
@ghost ghost added this to the Next milestone Jul 28, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
JoeRobich added a commit that referenced this pull request May 2, 2022
@JoeRobich
Backport correctness fixes from #54997
d5b10a6
JoeRobich added a commit that referenced this pull request May 2, 2022
@JoeRobich
Backport dependency version changes from #54997
6c3966c
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Infrastructure auto-merge
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeRobich @RikkiGibson @dibarbet