Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arcade and require .NET 6 Preview 7 SDK #55681

Merged
merged 23 commits into from
Aug 19, 2021
Merged

Conversation

JoeRobich
Copy link
Member

Arcade is currently pushing early builds of .NET 6 RC which would be difficult to require contributors to install in order to develop against Roslyn. This moves us to the latest published Preview version and brings in recent Arcacde changes.

dotnet-maestro bot and others added 7 commits August 5, 2021 12:14
…803.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21403.5
…806.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21406.6
…810.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21410.8
…812.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21412.1
…813.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21413.4
@JoeRobich JoeRobich requested review from a team as code owners August 17, 2021 23:06
@RikkiGibson
Copy link
Contributor

Do we know why they are pushing such new versions of the SDK?

@JoeRobich
Copy link
Member Author

Do we know why they are pushing such new versions of the SDK?

I have not asked. I assumed it was to get RC as much validation as possible before it gets released.

@dibarbet
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jkoritzinsky
Copy link
Member

Arcade moved to the RC1 SDK to help alleviate NuGet feed instability that dotnet/aspnetcore and dotnet/runtime were hitting at extremely high frequency.

@dibarbet
Copy link
Member

dibarbet commented Aug 19, 2021

The test CsiScript_WithSourceCodeRedirectedViaStandardInput_ExecutesNonInteractively is failing when targeting net5.0 (but not when targeting net472).

Compilation error(s) occurred:  System.TypeLoadException: Could not load type 'System.Int32' from assembly 'R*ad9ddb7c-7900-42d3-b5d7-ff74566f9be0#1-0, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' due to value type mismatch.
  + System.Delegate.BindToMethodInfo(object, System.IRuntimeMethodInfo, System.RuntimeType, System.DelegateBindingFlags)
  + System.Reflection.RuntimeMethodInfo.CreateDelegateInternal(System.Type, object, System.DelegateBindingFlags)
  + System.Reflection.RuntimeMethodInfo.CreateDelegate(System.Type)
  + Roslyn.Utilities.ReflectionUtilities.CreateDelegate<T>(System.Reflection.MethodInfo) at C:\Users\dabarbet\source\repos\roslyn\src\Compilers\Core\Portable\InternalUtilities\ReflectionUtilities.cs : 115
  + Microsoft.CodeAnalysis.Scripting.ScriptBuilder.Build<T>(Microsoft.CodeAnalysis.Compilation, Microsoft.CodeAnalysis.DiagnosticBag, bool, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\ScriptBuilder.cs : 166
  + Microsoft.CodeAnalysis.Scripting.ScriptBuilder.CreateExecutor<T>(Microsoft.CodeAnalysis.Scripting.ScriptCompiler, Microsoft.CodeAnalysis.Compilation, bool, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\ScriptBuilder.cs : 88
  + Script<T>.GetExecutor(System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\Script.cs : 365
  + Script<T>.RunAsync(object, Func<System.Exception, bool>, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\Script.cs : 469
  + Script<T>.RunAsync(object, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\Script.cs : 443

Expected: False
Actual:   True

@dotnet/roslyn-compiler could I get some assistance tracking down this issue? It is easy to repro locally by just checking out this branch. I haven't found anything obvious after a cursory investigation, but I'm very unfamiliar with this bit. Feel free to push to the branch. If the test failure is not important, let me know and I can disable it.

@dibarbet dibarbet force-pushed the dev/jorobich/update-sdk branch from 163cb5a to 17683dc Compare August 19, 2021 04:24
Format.cmd Outdated Show resolved Hide resolved
dotnet-tools.json Outdated Show resolved Hide resolved
eng/format.ps1 Outdated Show resolved Hide resolved
eng/format.sh Outdated Show resolved Hide resolved
format.sh Outdated Show resolved Hide resolved
@JoeRobich
Copy link
Member Author

The Linux_Single machine tests have passed. Merging this in since we haven't seen issues in the MacOS leg during previous runs and this unblocks CI.

@JoeRobich JoeRobich merged commit 398d7b6 into main Aug 19, 2021
@ghost ghost added this to the Next milestone Aug 19, 2021
@RikkiGibson RikkiGibson deleted the dev/jorobich/update-sdk branch August 19, 2021 23:30
allisonchou pushed a commit to allisonchou/roslyn that referenced this pull request Aug 20, 2021
Update Arcade and require .NET 6 Preview 7 SDK
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants