Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge FixIdDefinition with the same name #57883

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Nov 19, 2021

When multiple fixes are exported with the same name, the editor cannot differentiate and configuration changes cannot be saved.

https://developercommunity.visualstudio.com/t/Configure-Code-Cleanup-selections-are-/1571097
Fixes AB#1429876

@sharwell sharwell requested a review from a team as a code owner November 19, 2021 17:46
@sharwell sharwell enabled auto-merge November 19, 2021 21:23
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test that just looks at our exports and verifies there aren't any duplicate names might be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants