Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3" #58814

Closed
wants to merge 1 commit into from

Conversation

CyrusNajmabadi
Copy link
Member

This reverts commit 83a728a, reversing
changes made to a4ec465.

We're seeing a bad perf regression around OOP that happeend over a period of time which included this risky change. This PR exists so we can make a build/insertion to see if it fixes the issue.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 12, 2022 23:58
@sharwell sharwell marked this pull request as draft January 12, 2022 23:58
@CyrusNajmabadi
Copy link
Member Author

@sharwell @jasonmalinowski for review. This does appear to be the source of some of hte memory regressions we've found. Verified by @genlu

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review January 13, 2022 22:29
@jasonmalinowski
Copy link
Member

@CyrusNajmabadi I signed off on the 17.1 version; if we decide not to take that I can re-sign off on this one too.

@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski do we need to take this? or will the 17.1 fix automatically merge into main?

@CyrusNajmabadi
Copy link
Member Author

Ok. This will flow into main naturally. Closing this out.

@CyrusNajmabadi CyrusNajmabadi deleted the revertBranchId branch January 20, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants