-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fading span for unnecessary using #59276
Conversation
@@ -172,8 +173,40 @@ static bool ShouldFade(AnalyzerOptions options, SyntaxTree tree, string language | |||
} | |||
} | |||
|
|||
protected virtual Func<SyntaxNode, SyntaxToken>? GetLastTokenDelegateForContiguousSpans() | |||
=> null; | |||
private IEnumerable<TextSpan> GetContiguousSpans(ImmutableArray<SyntaxNode> nodes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a move from an extension method to the single feature that used it.
@@ -977,5 +977,34 @@ public async Task TestAfterFileScopedNamespace() | |||
@"namespace N; | |||
$$"); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. part of another fix. will break out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The using span changes look good. Let me know when the PR is fixed up and I'll give it a final look over.
Fixes #1322