Code

Remaining fallback options#60888

Code

Merged

tmat merged 59 commits intodotnet:maindotnet/roslyn:mainfrom tmat:RemainingFallbackOptionstmat/roslyn:RemainingFallbackOptionsCopy head branch name to clipboardMay 18, 2022

+5,093-3,911

Commits

Commits on May 17, 2022

• Add missing fallbacks

  tmat

  committed
  4e08611

• Fallback options from ILegacyGlobalOptionsWorkspaceService

  tmat

  committed
  5691159

• Pass options to CodeCleaner APIs.

  tmat

  committed
  241e6f3

• Fallback options from ILegacyGlobalOptionsWorkspaceService 2

  tmat

  committed
  13f2579

• Fallback in tests

  tmat

  committed
  122e673

• CodeModel

  tmat

  committed
  8d33b10

• Remove CodeActionOptions.Default

  tmat

  committed
  3797fc7

• Remove dependency on IGlobalOptionService from inline hints service

  tmat

  committed
  df98b9b

• Remove obsolete VS UnitTesting APIs.

  tmat

  committed
  8277c80

• Remote dependency on IGlobalOption service from RemoteProcessTelemetryService

  tmat

  committed
  fc54437

• Remove ExportGlobalOptionProviderAttribute

  tmat

  committed
  d2d6983

• Remove PythiaOptions

  tmat

  committed
  31d526f

• Remove DiagnosticOptions from solution snapshot

  tmat

  committed
  7da1b7d

• Access options via AnalyzerOptionsProvider

  tmat

  committed
  8e4c844

• Split ISyntaxFormatting.cs

  tmat

  committed
  8801fbc

• Simplify initializers

  tmat

  committed
  4c25b2d

• Fix

  tmat

  committed
  308a377

• Move AddImportPlacementOptions to a separate file in compiler extensions

  tmat

  committed
  ce92bb8

• Move option providers to workspace extensions

  tmat

  committed
  8a8f03f

• Move CodeCleanupOptions and IdeAnalyzerOptions to workspace extensions

  tmat

  committed
  8303a11

• Layering

  tmat

  committed
  b466f35

• Replace legacy GetOptions with AnalyzerOptionsProvider; add missing options

  tmat

  committed
  7d7f18f

• Parameter rename, comment

  tmat

  committed
  8b20516

• Add LineFormattingOptionsProviders

  tmat

  committed
  65157cc

• CodeFixOptionsProvider, include CodeStyleOptions in CodeActionOptions, include LineFormattingOptions in ExtractMethodGenerationOptions

  tmat

  committed
  999b8d7

• DocumentFormattingOptions

  tmat

  committed
  291c685

• Move a couple of options from IdeCodeStyle to SyntaxFormatting to make them available to new document formatter

  tmat

  committed
  4623261

• Generalize using placement option in AddImportPlacementOptions

  tmat

  committed
  660dcee

• Move PreferParameterNullChecking and AllowEmbeddedStatementsOnSameLine to CSharpSimplifierOptions

  tmat

  committed
  f822b74

• Move CodeGen options to compiler extensions

  tmat

  committed
  35f22da

• UseExpressionBody

  tmat

  committed
  be9add5

• Eliminate more calls to Document.GetOptionsAsync

  tmat

  committed
  dc814f8

• Cleanup DocumentationCommentOptions

  tmat

  committed
  751b3eb

• Line formatting options

  tmat

  committed
  424c6de

• DefaultConditionalExpressionWrappingLength

  tmat

  committed
  22e6401

• insert_final_newline

  tmat

  committed
  5751d1f

• Add PreferThrowExpression to simplifier options

  tmat

  committed
  8d4bee3

• Add AddNullChecksToConstructorsGeneratedFromMembers to CodeGenOptions

  tmat

  committed
  5561c2a

• GenerateEqualsAndGetHashCodeFromMembersOptions

  tmat

  committed
  ec4a22f

• IImplementInterfaceService

  tmat

  committed
  431c0a1

• AddParameterCheckCodeRefactoringProvider

  tmat

  committed
  86fc777

• ReplaceMethodWithPropertyService

  tmat

  committed
  9b51537

• NamingStylePreferences

  tmat

  committed
  f9fabaf

• Eliminate legacy option helpers

  tmat

  committed
  4e29eba

• Fix up ExtractMethod options

  tmat

  committed
  a007be4

• Remove SyntaxFormattingOptions ctors

  tmat

  committed
  57a8c10

• Replace extra helpers with CodeFixOptionsProvider

  tmat

  committed
  23b05c2

• PreferUtf8StringLiterals

  tmat

  committed
  d3c0742

• RazorLineFormattingOptionsStorage

  tmat

  committed
  a2b21d0

• Remove usage of Document.GetOptionsAsync - 1

  tmat

  committed
  d03699e

• Remove internal usage of DocumentOptionSet and Document.GetOptionsAsync

  tmat

  committed
  c30c56e

• Simplify and unify option definition patterns

  tmat

  committed
  c652494

• Fixes and pattern unification

  tmat

  committed
  c5181d2

• Serialization and equality

  tmat

  committed
  dfd34a9

• Simplify

  tmat

  committed
  779a9b9

• Rename

  tmat

  committed
  2d5681b

• Fixes

  tmat

  committed
  e5544c3

• CompletionOption fixes

  tmat

  committed
  16d1133

Commits on May 18, 2022

• Feedback

  tmat

  committed
  132de05