Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Disable GoToDef/GoToImpl integration tests #61190

Merged
merged 3 commits into from
May 15, 2022
Merged

[LSP] Disable GoToDef/GoToImpl integration tests #61190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f2805a
[LSP] Disable GoToDef/GoToImpl integration tests
allisonchou May 9, 2022
6d7cd2f
[LSP] Disable GoToDef/GoToImpl integration tests
allisonchou May 9, 2022
5ee295c
Update CSharpClassification.cs
allisonchou May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpClassification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ static void Main(string[] args)
VisualStudio.Editor.Verify.CurrentTokenType(tokenType: "class name");
}

[WpfFact, Trait(Traits.Feature, Traits.Features.Classification), Trait(Traits.Editor, Traits.Editors.LanguageServerProtocol)]
Copy link
Contributor Author

@allisonchou allisonchou May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command to change build configurations also doesn't seem to be working on the integration test machines in LSP scenarios (despite passing on my machine). However, I manually verified that things work as expected in an actual LSP scenario.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm - I think without this trait the LSP tests won't run this test, is that intentional in this PR?

we should also trigger an LSP run on this PR - should be /azp run roslyn-integration-lsp-CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional because the test is failing in the LSP integration run I kicked off:
https://dev.azure.com/dnceng/public/_build/results?buildId=1760627&view=results

I think it'll warrant further investigation but this seems to be a test issue + not an issue when manually testing

[WpfFact, Trait(Traits.Feature, Traits.Features.Classification)]
public void VerifyProjectConfigChange()
{
VisualStudio.Editor.SetText(@"
Expand Down
6 changes: 3 additions & 3 deletions src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpGoToDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public CSharpGoToDefinition()
{
}

[IdeFact, Trait(Traits.Editor, Traits.Editors.LanguageServerProtocol)]
[IdeFact]
public async Task GoToClassDeclaration()
{
var project = ProjectName;
Expand All @@ -48,7 +48,7 @@ await TestServices.Editor.SetTextAsync(
Assert.False(await TestServices.Shell.IsActiveTabProvisionalAsync(HangMitigatingCancellationToken));
}

[IdeFact, Trait(Traits.Editor, Traits.Editors.LanguageServerProtocol)]
[IdeFact]
public async Task GoToDefinitionOpensProvisionalTabIfDocumentNotAlreadyOpen()
{
var project = ProjectName;
Expand All @@ -74,7 +74,7 @@ await TestServices.Editor.SetTextAsync(
Assert.True(await TestServices.Shell.IsActiveTabProvisionalAsync(HangMitigatingCancellationToken));
}

[IdeFact, Trait(Traits.Editor, Traits.Editors.LanguageServerProtocol)]
[IdeFact]
public async Task GoToDefinitionWithMultipleResults()
{
await SetUpEditorAsync(
Expand Down
4 changes: 2 additions & 2 deletions src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpGoToImplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public CSharpGoToImplementation()
{
}

[IdeTheory, Trait(Traits.Editor, Traits.Editors.LanguageServerProtocol)]
[IdeTheory]
[CombinatorialData]
public async Task SimpleGoToImplementation(bool asyncNavigation)
{
Expand Down Expand Up @@ -75,7 +75,7 @@ await TestServices.Editor.SetTextAsync(
Assert.False(await TestServices.Shell.IsActiveTabProvisionalAsync(HangMitigatingCancellationToken));
}

[IdeTheory, Trait(Traits.Editor, Traits.Editors.LanguageServerProtocol)]
[IdeTheory]
[CombinatorialData]
public async Task GoToImplementationOpensProvisionalTabIfDocumentNotOpen(bool asyncNavigation)
{
Expand Down