Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Encapsulte Field' to use the new background work indicator. #61531

Merged
merged 7 commits into from
May 26, 2022

Conversation

CyrusNajmabadi
Copy link
Member

Looks like this:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 26, 2022 16:24
return false;

// Fire and forget
var token = _listener.BeginAsyncOperation("EncapsulateField");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have a FeatureAttribute constant here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ick. let me add.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 26, 2022 16:59
@CyrusNajmabadi CyrusNajmabadi merged commit 1db7eeb into dotnet:main May 26, 2022
@ghost ghost added this to the Next milestone May 26, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the asyncEncapsulateField branch May 26, 2022 19:55
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants