[EnC] Allow deleting method #61806
Merged
[EnC] Allow deleting method #61806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
force-pushed
the
EnCDeleteMethod
branch
2 times, most recently
from
fe3ee19 to
253bae5
Compare
cston
reviewed
Jun 23, 2022
| } | ||
| """, | ||
| edits: new[] { | ||
| Edit(SemanticEditKind.Insert, symbolProvider: c => c.GetMember("C.M1")), |
There was a problem hiding this comment.
Yes, but only during emit. So the analyzer still sees it as an insert and still reports the semantic edit as such, which is what this represents, but then in DeltaMetadataWriter (here) that gets treated as an update.
cston
reviewed
Jun 23, 2022
src/EditorFeatures/TestUtilities/EditAndContinue/EditAndContinueTestHelpers.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Jun 23, 2022
|
@dotnet/roslyn-compiler for a second review, please |
|
Ping @tmat |
chsienki
approved these changes
Jun 27, 2022
tmat
reviewed
Jun 27, 2022
tmat
reviewed
Jun 27, 2022
src/EditorFeatures/CSharpTest/EditAndContinue/TopLevelEditingTests.cs
Outdated
Show resolved
Hide resolved
|
Just a few minor things. |
ghost
added this to the
|
Nice! |
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61678
Part of #59264
This allows deleting a method in Edit and Continue/Hot Reload. When deleted, we emit a method that throws
MissingMethodExceptionin its place. If a method by the same is name is re-added, we emit an update, as though the method wasn't deleted in the first place.