Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include parens in crefs when necessary to disambiguate items #67140

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Include parens in crefs when necessary to disambiguate items #67140

merged 1 commit into from
Mar 6, 2023

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #43139

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 1, 2023 22:46
@CyrusNajmabadi CyrusNajmabadi merged commit c10fcd3 into dotnet:main Mar 6, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the ambiguousCref branch March 6, 2023 17:32
@ghost ghost added this to the Next milestone Mar 6, 2023
@allisonchou allisonchou mentioned this pull request Mar 9, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.6 P3 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.6 P3
Development

Successfully merging this pull request may close these issues.

Completion for methods within a cref do not include enough info to disambiguate
3 participants
@CyrusNajmabadi @akhera99 @allisonchou