Skip checks for overridden or hidden members in overload resolution with extension methods #68316
Conversation
…ith extension methods
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
| in CallingConventionInfo callingConventionInfo = default) | ||
| where TMember : Symbol | ||
| { | ||
| var results = result.ResultsBuilder; | ||
|
|
||
| // No need to check for overridden or hidden methods | ||
| // if the members were resolved as extension methods. | ||
| bool checkOverriddenOrHidden = !isExtensionMethodResolution; |
There was a problem hiding this comment.
Should we confirm that all containing types are static types derived from System.Object?
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dotnet/roslyn-compiler for a second review, thanks. |
src/Compilers/CSharp/Test/Semantic/Semantics/OverloadResolutionPerfTests.cs
Show resolved
Hide resolved
| var refA = CompileIL(sourceA, prependDefaultHeader: false); | ||
|
|
||
| // The calls to B.F3(o) and o.F3() should bind to B.F3 and should not be | ||
| // considered ambiguous with A.F3 because B is derived from A. |
There was a problem hiding this comment.
Does the language specify this?
There was a problem hiding this comment.
I'm not sure if the language specifies this, but this is the existing behavior, so I wanted to avoid an unnecessary breaking change.
| // No need to check for overridden or hidden methods if the members were | ||
| // resolved as extension methods and the extension methods are defined in | ||
| // types derived from System.Object. | ||
| bool checkOverriddenOrHidden = !(isExtensionMethodResolution && |
There was a problem hiding this comment.
nit: it feels like this might be easier to understand as !isExtensionMethodResolution || !members.All(...)
There was a problem hiding this comment.
To me, both forms seem equally difficult to read. I'll leave it as is since the current form matches the comment above which seems relatively clear.
| in CallingConventionInfo callingConventionInfo = default) | ||
| where TMember : Symbol | ||
| { | ||
| var results = result.ResultsBuilder; | ||
|
|
||
| // No need to check for overridden or hidden methods if the members were | ||
| // resolved as extension methods and the extension methods are defined in | ||
| // types derived from System.Object. |
There was a problem hiding this comment.
Is this optimization only applicable for extension method overload resolution? What about normal static method overload resolution?
There was a problem hiding this comment.
I limited the optimization to extension methods because it was easy to catch that case in the caller. I think it's less likely there is an issue with static method overloads since the containing types in that case would need to be in the same class or base classes, so few containing types and, as a result, few entries in the dictionary returned from PartitionMembersByContainingType().
ghost
added this to the 
…ith extension methods (dotnet#68316)
Improves Intellisense performance by ~35% for scenario in #67926.