Misc improvements of OneOrMany #68948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
reviewed
Jul 10, 2023
src/Compilers/Core/CodeAnalysisTest/InternalUtilities/OneOrManyTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 10, 2023
jaredpar
removed
the
untriaged
jjonescz
approved these changes
Jul 10, 2023
|
this type seems to have a lot of brokennes :'( |
CyrusNajmabadi
approved these changes
Jul 10, 2023
jaredpar
reviewed
Jul 13, 2023
| if (many is [var item]) | ||
| { | ||
| _one = item; | ||
| _many = default; |
There was a problem hiding this comment.
I understand this makes the internal invariants of the type a lot simpler but it does mean we essentially introduce allocations for this pattern where before there was no allocation:
var array = ImmutableArray.Create<int>(42);
var oneOrMany = new OneOrMany<int>(array);
// Before no alloc, after allocs
oneOrMany.ToImmutable();Are we concerned this could regress allocations? Don't have a guid intuition on how common this would be.
There was a problem hiding this comment.
Yes, potentially. I don't think it's common since we usually know at creation time that we only have a single element so we wouldn't create that array.
jaredpar
approved these changes
Jul 14, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom debugger display.
Adds
SequenceEqualand a few convenience helpers.