Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the new RefKind.RefReadonlyParameter sequential #69033

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Make the new RefKind.RefReadonlyParameter sequential #69033

merged 1 commit into from
Jul 17, 2023

Conversation

jjonescz
Copy link
Member

Follow up on #68179 (comment).
Test plan: #68056

@jjonescz jjonescz added the New Feature - Ref Readonly Parameters `ref readonly` parameters label Jul 14, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 14, 2023
@jjonescz jjonescz changed the title Make the new ref readonly ref kind sequential Make the new RefKind.RefReadonlyParameter sequential Jul 14, 2023
@jjonescz jjonescz marked this pull request as ready for review July 14, 2023 13:23
@jjonescz jjonescz requested review from a team as code owners July 14, 2023 13:23
@jjonescz jjonescz requested review from AlekseyTs and jcouv July 14, 2023 13:23
AlekseyTs
AlekseyTs approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jjonescz jjonescz merged commit 201bce0 into dotnet:features/RefReadonly Jul 17, 2023
25 checks passed
@jjonescz jjonescz deleted the RefReadonly-12-RenumberRefKind branch July 17, 2023 07:03
@allisonchou allisonchou mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

@jcouv jcouv Awaiting requested review from jcouv

Assignees
No one assigned
Labels
Area-Compilers New Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjonescz @AlekseyTs @cston