Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CollectionLiteralTests.cs to Emit2 #69058

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Move CollectionLiteralTests.cs to Emit2 #69058

merged 1 commit into from
Jul 17, 2023

Conversation

cston
Copy link
Member

@cston cston commented Jul 16, 2023

Maximum string space exceeded in Semantic project.

@cston cston requested a review from a team as a code owner July 16, 2023 15:46
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 16, 2023
@alrz
Copy link
Member

alrz commented Jul 16, 2023

Would it make sense to use u8 strings in tests?

@cston
Copy link
Member Author

cston commented Jul 17, 2023 •
edited
Loading

Would it make sense to use u8 strings in tests?

That sounds reasonable. Please feel free to log an issue.

To use u8 strings in tests, we'd need to add overloads of CreateCompilation(), CompileAndVerify(), VerifyIL(), etc. that take ReadOnlySpan<byte>. And for debugging, it would be useful to display u8 strings in the debugger as strings, not just as spans of bytes.

@cston cston merged commit 7585eab into dotnet:main Jul 17, 2023
@cston cston deleted the move-collection-tests branch July 17, 2023 14:42
@ghost ghost added this to the Next milestone Jul 17, 2023
@allisonchou allisonchou mentioned this pull request Jul 18, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjonescz jjonescz jjonescz approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@cston @alrz @jjonescz @allisonchou