Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce bool array allocations in MethodTypeInferrer.FixParameters #69069

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Reduce bool array allocations in MethodTypeInferrer.FixParameters #69069

merged 1 commit into from
Jul 18, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 17, 2023 •
edited
Loading

Address 1.1% allocations of boolean arrays in MethodTypeInferrer.FixParameters. Fixes #56012

image

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 17, 2023 20:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 17, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 17, 2023
@Youssef1313 Youssef1313 mentioned this pull request Jul 17, 2023
Merged
AlekseyTs
AlekseyTs approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs AlekseyTs enabled auto-merge (squash) July 18, 2023 05:17
@AlekseyTs AlekseyTs merged commit e85f97f into dotnet:main Jul 18, 2023
@ghost ghost added this to the Next milestone Jul 18, 2023
@Youssef1313 Youssef1313 deleted the bool-array-alloc branch July 18, 2023 06:42
@AlekseyTs
Copy link
Contributor

@Youssef1313 Thanks for the contribution.

@allisonchou allisonchou mentioned this pull request Jul 18, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.

Use a BitVector instead of bool[] in MethodTypeInferrer.FixParameters
4 participants
@Youssef1313 @AlekseyTs @cston @allisonchou