Allow parsing ref readonly parameters in cref
#69104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
force-pushed
the
RefReadonly-17-CrefParsing
branch
2 times, most recently
from
308e1b2 to
cd16b91
Compare
jjonescz
force-pushed
the
RefReadonly-17-CrefParsing
branch
from
cd16b91 to
d2c7205
Compare
jcouv
reviewed
Jul 19, 2023
|
|
||
| var parameterSymbol = ((IMethodSymbol)model.GetSymbolInfo(cref).Symbol).Parameters.Single(); | ||
| Assert.Equal(RefKind.In, parameterSymbol.RefKind); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CRef_RefReadonlyParameter() |
There was a problem hiding this comment.
Consider also testing readonly ref (error) #Resolved
jcouv
removed
the
untriaged
jjonescz
force-pushed
the
RefReadonly-17-CrefParsing
branch
from
da231e3 to
4ec46b2
Compare
AlekseyTs
reviewed
Jul 20, 2023
AlekseyTs
reviewed
Jul 20, 2023
src/Compilers/CSharp/Portable/Parser/DocumentationCommentParser.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 20, 2023
AlekseyTs
reviewed
Jul 20, 2023
AlekseyTs
reviewed
Jul 20, 2023
| /// there is no name and there are no attributes or other modifiers. | ||
| /// </summary> | ||
| internal sealed partial class CrefParameterSyntax : CSharpSyntaxNode | ||
| { | ||
| internal readonly SyntaxToken? refKindKeyword; | ||
| internal readonly SyntaxToken? readOnlyKeyword; |
There was a problem hiding this comment.
another, possibly cleaner, way to do this is to just changet this to a TokenList of Modifiers.
AlekseyTs
reviewed
Jul 20, 2023
|
Done with review pass (commit 2) |
AlekseyTs
reviewed
Jul 21, 2023
src/Compilers/CSharp/Portable/Parser/DocumentationCommentParser.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 21, 2023
src/Compilers/CSharp/Portable/Parser/DocumentationCommentParser.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 21, 2023
|
Done with review pass (commit 7) |
AlekseyTs
reviewed
Jul 21, 2023
jcouv
reviewed
Jul 25, 2023
| // (3,16): error CS8652: The feature 'ref readonly parameters' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. | ||
| // void M(ref readonly int x) | ||
| Diagnostic(ErrorCode.ERR_FeatureInPreview, "readonly").WithArguments("ref readonly parameters").WithLocation(3, 16), | ||
| // (8,26): warning CS1658: The feature 'ref readonly parameters' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.. See also error CS8652. |
There was a problem hiding this comment.
not related to this PR: I'm curious whether this warning override will trigger the IDE fixer to turn on the preview LangVer. This would be a pre-existing issue. May need to file an issue
There was a problem hiding this comment.
It won't. Filed #69228.
jcouv
reviewed
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #68056