Ensure proper definite assignment analysis for an inline array that is not supported by language. #69212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not supported by language.
dotnet-issue-labeler
bot
added
the
untriaged
cston
reviewed
Jul 25, 2023
| @@ -11863,10 +11883,20 @@ | |||
| { | |||
| public T _element0; | |||
| } | |||
|
|
|||
| [System.Runtime.CompilerServices.InlineArray(1)] | |||
| public ref struct Buffer2Ref | |||
There was a problem hiding this comment.
Buffer1Ref?
There isn't a requirement like that.
cston
reviewed
Jul 25, 2023
| [System.Runtime.CompilerServices.InlineArray(1)] | ||
| public ref struct Buffer1Ref | ||
| { | ||
| public ref int _element2; |
There was a problem hiding this comment.
Consider renaming to _element0 so it's clear the name is not important.
The name is distinct so that it is easy to see what line causes an error. I will keep it as is.
cston
approved these changes
Jul 25, 2023
|
@jjonescz, @dotnet/roslyn-compiler For the second review |
jjonescz
approved these changes
Jul 26, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to test plan #67826