Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend this after ref readonly #69255

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Recommend this after ref readonly #69255

merged 2 commits into from
Jul 27, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 27, 2023 •
edited
Loading

Test plan: #68056

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 27, 2023
@jjonescz jjonescz added the New Feature - Ref Readonly Parameters `ref readonly` parameters label Jul 27, 2023
@jjonescz jjonescz marked this pull request as ready for review July 27, 2023 11:39
@jjonescz jjonescz requested a review from a team as a code owner July 27, 2023 11:39
@jjonescz jjonescz requested review from jcouv and akhera99 July 27, 2023 13:37
CyrusNajmabadi
CyrusNajmabadi reviewed Jul 27, 2023
View reviewed changes
src/EditorFeatures/CSharpTest2/Recommendations/ThisKeywordRecommenderTests.cs Outdated
{
await VerifyAbsenceAsync(
@"class C {
void Goo(in $$");
void Goo(" + modifier + @" $$");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use interpolated strings

CyrusNajmabadi
CyrusNajmabadi approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with test update.

CyrusNajmabadi
CyrusNajmabadi reviewed Jul 27, 2023
View reviewed changes
src/EditorFeatures/CSharpTest2/Recommendations/ThisKeywordRecommenderTests.cs
{
await VerifyAbsenceAsync(
@"class C {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating to raw strings :)

@jjonescz jjonescz merged commit 319059b into dotnet:main Jul 27, 2023
24 checks passed
@jjonescz jjonescz deleted the RefReadonly-22-ThisRecommender branch July 27, 2023 18:21
@ghost ghost added this to the Next milestone Jul 27, 2023
@allisonchou allisonchou mentioned this pull request Aug 2, 2023
Closed
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@akhera99 akhera99 akhera99 approved these changes

@jcouv jcouv Awaiting requested review from jcouv

Assignees
No one assigned
Labels
Area-IDE New Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @CyrusNajmabadi @akhera99 @dibarbet