Fix CodeStylePage EditorConfigOptionsGenerator service #69425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
beccamc
changed the title
|
Would love an integration test here. clearly things are def fragile. |
CyrusNajmabadi
approved these changes
Aug 7, 2023
jasonmalinowski
approved these changes
Aug 7, 2023
arkalyanms
approved these changes
Aug 7, 2023
| @@ -23,7 +18,8 @@ internal class CodeStylePage : AbstractOptionPage | |||
| { | |||
| protected override AbstractOptionPageControl CreateOptionPage(IServiceProvider serviceProvider, OptionStore optionStore) | |||
| { | |||
| var editorService = (EditorConfigOptionsGenerator)serviceProvider.GetService(typeof(EditorConfigOptionsGenerator)); | |||
| var editorService = serviceProvider.GetMefService<EditorConfigOptionsGenerator>(); | |||
There was a problem hiding this comment.
do we need test added for this going forward?
3 tasks
|
Going to work offline with Sam for adding a test. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Code style options page for C# and VB.