Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce LOH allocations for SemanticToken classification in LSP #69496

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Reduce LOH allocations for SemanticToken classification in LSP #69496

merged 2 commits into from
Aug 15, 2023

Commits on Aug 14, 2023

  1. Reduce LOH allocations for SemanticToken classification in LSP 

    LSP semantic classification classifies the whole document per call. This ends up with a large number of classifiedspans per call, enough so that the standard ArrayBuilder cache ends up throwing away it's values upon Free. Instead, use the Classifier's pooled list, as it doesn't have the size limit for it's cache.

This accounts for about 0.5% of LOH allocations in the devenv process in the customer profile that I'm looking at.
    @ToddGrun
    ToddGrun committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    47bd370 View commit details
    Browse the repository at this point in the history

  2. Remove accidental remnants of earlier attempt I made locally and didn… 

    …'t fullly revert.
    @ToddGrun
    ToddGrun committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9747fdf View commit details
    Browse the repository at this point in the history