Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsplit NullableWalker after out argument #69511

Merged

Conversation

jjonescz
Copy link
Member

Fixes #67816.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 15, 2023
@jjonescz jjonescz marked this pull request as ready for review August 15, 2023 14:01
@jjonescz jjonescz requested a review from a team as a code owner August 15, 2023 14:01
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Aug 15, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 15, 2023
@jcouv jcouv merged commit 00c15ab into dotnet:main Aug 16, 2023
25 checks passed
@ghost ghost added this to the Next milestone Aug 16, 2023
Comment on lines 6682 to 6683
// As far as we can tell, there is no scenario relevant to nullability analysis
// where splitting an L-value (for instance with a ref conditional) would affect the result.
Copy link
Member

@Youssef1313 Youssef1313 Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcouv @jjonescz Is this comment outdated now? Nope, misread it. Sorry.

@jjonescz jjonescz deleted the 67816-NullableWalker-OutConditionalState branch August 16, 2023 06:49
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRE in NullableWalker while editing code
5 participants