Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement null conditional await #70916

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thinker227
Copy link

Implement "null-conditional await" (dotnet/csharplang #35).

Pull is currently a heavy work-in-progress: It's also my first pr to Roslyn so I'll have to take some time to figure out how to implement everything properly.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 21, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 21, 2023
@huoyaoyuan
Copy link
Member

You can check my implementation at https://github.com/huoyaoyuan/roslyn/tree/features/conditional-await

It's also my first pr to Roslyn

I don't suggest new contributor to start with language feature. It can involve much more than you may initially considered. I started with built-in analyzers first, which are simple to test and not depended by others.

@thinker227
Copy link
Author

thinker227 commented Nov 23, 2023

@huoyaoyuan
I've written several standalone analyzers and source generators in the past and have studied the Roslyn codebase a fair bit and wanted to try contribute with something, and this seemed like a good simple-ish first contribution. But sure, if this isn't a necessary pr then I'll try find something else/simpler to contribute with, though I haven't really been able to find any other good first issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants