-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not resolve diagnostics early during attribute binding #71140
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7cd01d6
Do not resolve diagnostics early during attribute binding
333fred 36e120f
Switch to a different approach. Instead of saving BindingDiagnosticBa…
333fred 94b0d76
Rename ImmutableBindingDiagnostic to ReadOnlyBindingDiagnostic to mor…
333fred 3c7fa2b
Fix BoundNodes.xml as well
333fred 9db1515
Fix VB build
333fred 90b2784
Never resolve ReadOnlyBindingDiagnostics during `ToReadOnlyAndFree`
333fred 47f13c0
Add VB versions of the tests, and fix a bug where `Nothing` was being…
333fred 5fb44f3
Revert "Never resolve ReadOnlyBindingDiagnostics during `ToReadOnlyAn…
333fred 92a0a6d
Restore missing overload
333fred 74f903b
Revert stray period
333fred File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change wasn't a cycle, we just clearly didn't have any tests covering it, as it is guaranteed to hit a
Debug.Assert
.