Fix intercepting a struct or enum base method #71655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
cston
reviewed
Jan 18, 2024
| // Program.cs(16,6): error CS9148: Interceptor must have a 'this' parameter matching parameter 'ref Program this' on 'Program.InterceptableMethod()'. | ||
| // [InterceptsLocation("Program.cs", 10, 23)] | ||
| Diagnostic(ErrorCode.ERR_InterceptorMustHaveMatchingThisParameter, @"InterceptsLocation(""Program.cs"", 10, 23)").WithArguments("ref Program this", "Program.InterceptableMethod()").WithLocation(16, 6)); | ||
| } |
cston
reviewed
Jan 18, 2024
|
|
||
| class C | ||
| { | ||
| public static void M<T>(T t) where T : struct, I |
There was a problem hiding this comment.
Or alternatively, perhaps remove all constraints and test a call to a virtual method on object.
static void M<T>(T t)
{
t.ToString();
}
cston
approved these changes
Jan 18, 2024
|
@jcouv for second review |
RikkiGibson
commented
Jan 19, 2024
| @@ -272,7 +272,11 @@ private void EmbedIfNeedTo(BoundExpression receiver, ImmutableArray<PropertySymb | |||
| if (needToReduce) | |||
| { | |||
| Debug.Assert(methodThisParameter is not null); | |||
| arguments = arguments.Insert(0, receiverOpt!); | |||
| Debug.Assert(receiverOpt?.Type is not null); | |||
| Debug.Assert(receiverOpt.Type.Equals(interceptor.Parameters[0].Type, TypeCompareKind.AllIgnoreOptions) | |||
There was a problem hiding this comment.
I can try to add a clarifying comment here in a follow-up PR.
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70841
When the original method is an instance method and interceptor is an extension, we have to adjust the receiver argument to pass it for the extension 'this' parameter. Receiver emit strategies such as 'ConstrainedCallVirt' are not available for an extension 'this' parameter, so we may need to insert an additional (generally boxing) conversion, to make the receiver argument actually match the parameter type.
See https://github.com/dotnet/roslyn/blob/main/docs/features/interceptors.md#signature-matching
In test
InterceptorEnumBaseMethod, for example, we lower the callvalue.ToString()as if it were callingOtherToStringin reduced form. In that case,valuemust be boxed.