-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac crash dumps #71706
Merged
Merged
Mac crash dumps #71706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Jan 18, 2024
3 tasks
@dotnet/roslyn-infrastructure PTAL |
333fred
approved these changes
Jan 19, 2024
jjonescz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gets us closer to fixing the crashes in our OSX queues.
The most important part of this change is getting actionable dumps on those queues.
RunTests
was updated to use a number ofDOTNET_
environment variables to limit the size of dumps there + produce .json summaries of crashes that at least give us stack data. Given that information I was able to identify several issues:The latter issue is random and thus OSX is still failing. This PR moves us forward though by addressing two of the problems and producing actionable data during the run.