Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #73408

Merged
merged 8 commits into from
May 16, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 9, 2024

Coherency update: Failed to perform coherency update for one or more dependencies. Please review the GitHub checks or run darc update-dependencies --coherency-only locally against darc-main-2d23f62f-5696-4b5e-9103-23a78af8f6f0 for more information.

From https://github.com/dotnet/arcade

  • Subscription: 111cfc79-5f9f-4acd-d8a2-08dc0c5899fd
  • Build: 20240515.1
  • Date Produced: May 15, 2024 2:22:34 PM UTC
  • Commit: 15eea424d3b2dd25a5c0b10e8adc8aeed50129a1
  • Branch: refs/heads/main

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 9, 2024
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

@dotnet-policy-service dotnet-policy-service bot added the Needs API Review Needs to be reviewed by the API review council label May 9, 2024
…515.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.24225.1 -> To Version 9.0.0-beta.24265.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies to ensure coherency [main] Update dependencies from dotnet/arcade May 15, 2024
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 15, 2024 21:18
@mmitche
Copy link
Member

mmitche commented May 15, 2024

@jaredpar

@jaredpar jaredpar requested a review from a team as a code owner May 16, 2024 01:12
@@ -58,7 +59,7 @@ This problem primarily comes from our use of polyfill APIs. To avoid this we emp

This comes up in two forms:

### Pattern for types
### Pattern for type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either "a type" or revert 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahah .. was trying to delee a space when VS Code was hanging. Apparently deleted too much.

dotnet-maestro bot added 2 commits May 16, 2024 11:29
…515.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.24225.1 -> To Version 9.0.0-beta.24265.1
…515.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.24225.1 -> To Version 9.0.0-beta.24265.1
@jaredpar jaredpar force-pushed the darc-main-2d23f62f-5696-4b5e-9103-23a78af8f6f0 branch from fa63385 to 4533a06 Compare May 16, 2024 18:30
@jaredpar
Copy link
Member

@dotnet/roslyn-infrastructure PTAL.

Note: the last commit is the work necessary to adjust our repo to working with a .NET 9 SDK.

This change adjusts our repo to working with the .NET 9 SDK.
@jaredpar jaredpar force-pushed the darc-main-2d23f62f-5696-4b5e-9103-23a78af8f6f0 branch from 4533a06 to 95b3302 Compare May 16, 2024 18:31
docs/contributing/Target Framework Strategy.md Outdated Show resolved Hide resolved
jaredpar and others added 2 commits May 16, 2024 12:35
Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
@jaredpar jaredpar merged commit f086d7c into main May 16, 2024
28 of 29 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 16, 2024
@dotnet-maestro dotnet-maestro bot deleted the darc-main-2d23f62f-5696-4b5e-9103-23a78af8f6f0 branch May 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants