Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update xaml tool #75348

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Oct 2, 2024

dotnet/roslyn-tools#1430 set updateXamlRoslynVersion default to be true.
It should fix https://dev.azure.com/dnceng/internal/_build/results?buildId=2550417&view=results
In old release branch this /src/Xaml/Versions.props doesn't exist.
So we need to pass that parameter.

@Cosifne Cosifne requested a review from a team as a code owner October 2, 2024 18:19
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 2, 2024
@RikkiGibson RikkiGibson enabled auto-merge (squash) October 3, 2024 20:55
@RikkiGibson RikkiGibson merged commit 8903f4b into dotnet:release/dev17.8 Oct 3, 2024
20 of 27 checks passed
akhera99 added a commit that referenced this pull request Oct 3, 2024
akhera99 added a commit that referenced this pull request Oct 3, 2024
* Don't update xaml tool (#75348)

* Revert "Don't update xaml tool (#75348)"

This reverts commit 8903f4b.

---------

Co-authored-by: Shen Chen <Cosifne@users.noreply.github.com>
Co-authored-by: Ankita Khera <ankitakhera@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants