Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visit collection expression elements as r-values in NullableWalker #75365

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Visit collection expression elements as r-values in NullableWalker #75365

merged 1 commit into from
Oct 4, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 3, 2024

Fixes #75343.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 3, 2024
@jjonescz jjonescz marked this pull request as ready for review October 3, 2024 13:51
@jjonescz jjonescz requested a review from a team as a code owner October 3, 2024 13:51
jcouv
jcouv approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Oct 3, 2024
@jjonescz jjonescz merged commit 3b64495 into dotnet:main Oct 4, 2024
36 checks passed
@jjonescz jjonescz deleted the 75343-BoolCE-NRTAssert branch October 4, 2024 09:46
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

Assert fails with collection expression of bools
3 participants
@jjonescz @RikkiGibson @jcouv