Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for 'Add null checks' in generate constructor #75370

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Oct 3, 2024

Fixes #75320

4f83d2a9-742a-48e0-9451-cc884c78231f

@ryzngard ryzngard requested a review from a team as a code owner October 3, 2024 22:50
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 3, 2024
VerticalContentAlignment="Center"
Margin="8,0,0,5"
AutomationProperties.LabeledBy="{Binding ElementName=OptionsLabel}"
Content="{Binding Title}"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had to be done to correctly associate the keyboard press with the checkbox (and is slightly more correct anyways)

@ryzngard ryzngard merged commit d7e8af5 into dotnet:main Oct 4, 2024
25 checks passed
@ryzngard ryzngard deleted the keyboard_shortcut_add_null_checks branch October 4, 2024 18:43
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyboard shortcut for "Add null checks" in Generate Constructor refactor
3 participants