Fix suggestions for dotted constant patterns in Color Color case #75373
+462
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
src/Workspaces/CSharp/Portable/Recommendations/CSharpRecommendationServiceRunner.cs
Outdated
Show resolved
Hide resolved
| var reinterpretedBinding = semanticModel.GetSpeculativeSymbolInfo(identifier.SpanStart, identifier, SpeculativeBindingOption.BindAsTypeOrNamespace); | ||
| var reinterpretedSymbol = reinterpretedBinding.GetAnySymbol(); | ||
|
|
||
| // The reinterpretation must be a type |
There was a problem hiding this comment.
because...?
(this comment explains what the code does, but not why).
There was a problem hiding this comment.
This was an oversight. We also want to allow other kinds of symbols like aliases, namespaces and types. Will update, including a reason.
src/Workspaces/CSharp/Portable/Recommendations/CSharpRecommendationServiceRunner.cs
Outdated
Show resolved
Hide resolved
| // Methods, properties, events, non-constant fields etc. are excluded since they are not constant expressions | ||
| bool FilterMember(ISymbol symbol) | ||
| { | ||
| return symbol is INamespaceOrTypeSymbol or IFieldSymbol { IsConst: true } |
There was a problem hiding this comment.
what about a constant local? can you add a test for that?
There was a problem hiding this comment.
Local symbols are not contained within a type or namespace, so we will never encounter those through the filtering. However, we should have tests to make sure they are not overlooked.
There was a problem hiding this comment.
Added tests showing the behavior in locals
|
Done with pass. looking good. |
CyrusNajmabadi
approved these changes
Oct 4, 2024
Open
3 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75350
After an offline conversation with @CyrusNajmabadi, this PR only addresses the IDE suggestions, without changing the behavior of binding the symbol, or the parsed syntax. We simply reinterpret the non-const symbol as a type and suggest off of the type symbol.