Allow suppressing foreach iteration variable nullability mismatch #75432
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
changed the title
| @@ -8703,7 +8704,7 @@ private TypeWithState VisitConversion( | |||
| bool canConvertNestedNullability = true; | |||
| bool isSuppressed = false; | |||
|
|
|||
| if (conversionOperand.IsSuppressed == true) | |||
| if (suppressed || conversionOperand.IsSuppressed) | |||
There was a problem hiding this comment.
Could you share some details on the set up of the situation? I gather that we have two stacked conversions that are not part of the same conversion group and the operand is suppressed, but I don't understand why.
If this setup is expected, should we just dig through conversions here when looking for the IsSuppressed flag? #Closed
There was a problem hiding this comment.
We are getting here from VisitForEachIterationVariables where we call VisitConversion on node.IterationVariableType - there is no suppression in that node subtree. The suppression is in the node.Expression subtree.
Note that the pre-existing ref case similarly checks for suppression via node.Expression is not BoundConversion { Operand.IsSuppressed: true }.
|
@dotnet/roslyn-compiler for second review. Thanks |
| @@ -8703,7 +8704,7 @@ private TypeWithState VisitConversion( | |||
| bool canConvertNestedNullability = true; | |||
| bool isSuppressed = false; | |||
|
|
|||
| if (conversionOperand.IsSuppressed == true) | |||
| if (suppressed || conversionOperand.IsSuppressed) | |||
There was a problem hiding this comment.
Would it be possible to unify the suppressed parameter with the isSuppressed local?
|
@RikkiGibson Please take another look. Thanks |
|
@RikkiGibson Please take another look. Thanks |
Fixes #75430.