Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance on SymbolCompletionProviderTests #75496

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Improve performance on SymbolCompletionProviderTests #75496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7f211c
Verification APIs
Rekkonnect Oct 11, 2024
25ea82c
Adjust tests as in previous PR
Rekkonnect Oct 12, 2024
2d105ca
Adjust a batch of tests
Rekkonnect Oct 12, 2024
6b6a5e8
Another batch of tests
Rekkonnect Oct 12, 2024
2a0f83d
Optimize more tests
Rekkonnect Oct 12, 2024
ef5cbd4
Fix formatting
Rekkonnect Oct 12, 2024
9580335
Suggestions and oversight fixes
Rekkonnect Oct 12, 2024
31ea0b2
Shorten record to ItemExpectation
Rekkonnect Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...atures/CSharpTest/Completion/CompletionProviders/AbstractCSharpCompletionProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@ private protected override Task BaseVerifyWorkerAsync(
displayTextPrefix, inlineDescription, isComplexTextEdit, matchingFilters, flags, options, skipSpeculation: skipSpeculation);
}

private protected override Task BaseVerifyWorkerAsync(
string code, int position, bool usePreviousCharAsTrigger, char? deletedCharTrigger, bool? hasSuggestionItem,
SourceCodeKind sourceCodeKind, ItemExpectation[] expectedResults,
List<CompletionFilter> matchingFilters, CompletionItemFlags? flags, CompletionOptions options, bool skipSpeculation = false)
{
return base.VerifyWorkerAsync(
code, position, usePreviousCharAsTrigger, deletedCharTrigger, hasSuggestionItem, sourceCodeKind,
expectedResults, matchingFilters, flags, options, skipSpeculation);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand this. it seems to be an overrride, which just calls the base, but passes all the values along. why have this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the implementation of BaseVerifyWorkerAsync calling the base VerifyWorkerAsync, not the same method. Since we do not override VerifyWorkerAsync here, we just call its base.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyrusNajmabadi if this is okay can we move the PR forward?


private protected override async Task VerifyWorkerAsync(
string code, int position,
string expectedItemOrNull, string expectedDescriptionOrNull,
Expand Down
Loading
Loading