Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source-build team references #75536

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

MichaelSimons
Copy link
Member

The @dotnet/source-build-internal team is being deprecated. All references to it were updated.

Included the renaming of SourceBuild.props to the new naming convention, DotNetBuild.props.

Related to dotnet/source-build#4645

Repo admins, please grant @dotnet/product-construction and @dotnet/source-build write access. You can remove access granted to @dotnet/source-build-internal.

@MichaelSimons MichaelSimons requested review from a team as code owners October 16, 2024 21:01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 16, 2024
@MichaelSimons MichaelSimons requested review from a team and removed request for a team October 16, 2024 21:01
@jasonmalinowski
Copy link
Member

@MichaelSimons GitHub is flagging this file as having errors as the teams being flagged aren't visible, is that expected?

@MichaelSimons
Copy link
Member Author

@MichaelSimons GitHub is flagging this file as having errors as the teams being flagged aren't visible, is that expected?

That's because of the note I included in the PR descriptions:

Repo admins, please grant @dotnet/product-construction and @dotnet/source-build write access. You can remove access granted to @dotnet/source-build-internal.

The validation is failing because the code owners must have write access.

@jasonmalinowski
Copy link
Member

@MichaelSimons Ah apologies, missed that last bit!

@MichaelSimons
Copy link
Member Author

Gentle ping @dotnet/roslyn-infrastructure. Can you please make the requested permission changes so that this PR can be merged? TIA

Repo admins, please grant @dotnet/product-construction and @dotnet/source-build write access. You can remove access granted to @dotnet/source-build-internal.

@jjonescz
Copy link
Member

@jaredpar

@jaredpar
Copy link
Member

Added the teams with write permission.

@jaredpar jaredpar merged commit 58df28f into dotnet:main Oct 23, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 23, 2024
@MichaelSimons MichaelSimons deleted the sb-cleanup branch October 23, 2024 18:07
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants