Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we only capture the BuildNumber when setting OriginalBuildNumber. #75616

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Oct 24, 2024

The PR Val pipeline sets BuildNumber to provide additional details about the PR. This breaks upon rerun because the step which captures the OriginalBuildNumber isn't expecting the extra detail. This PR splits off the extra details when setting OriginalBuildNumber.

Test PR Val Run

The PR Val pipeline sets BuildNumber to provide additional details about the PR. This breaks upon rerun because the step which captures the OriginalBuildNumber isn't expecting the extra detail. This PR splits off the extra details when setting OriginalBuildNumber.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 24, 2024
@JoeRobich JoeRobich marked this pull request as ready for review October 24, 2024 07:17
@JoeRobich JoeRobich requested a review from a team as a code owner October 24, 2024 07:17
@arunchndr arunchndr merged commit ea13488 into main Oct 24, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 24, 2024
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
@JoeRobich JoeRobich deleted the dev/jorobich/fix-prval-rerun branch December 20, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants