Use absolute path for CompilerGeneratedFilesOutputPath #75713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jaredpar
reviewed
Nov 4, 2024
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| <!-- Enable output of generated files back into our Generated directory --> | |||
| <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | |||
| <CompilerGeneratedFilesOutputPath>Generated</CompilerGeneratedFilesOutputPath> | |||
| <CompilerGeneratedFilesOutputPath>$(MSBuildThisFileDirectory)\Generated</CompilerGeneratedFilesOutputPath> | |||
There was a problem hiding this comment.
Can we add a note to the issue to undo this change and put a link to the issue here?
There was a problem hiding this comment.
We don't necessarily need to undo it, absolute path should work always
There was a problem hiding this comment.
Yeah, I'm fine with leaving it as absolute as in the project file it means the same thing ultimately.
There was a problem hiding this comment.
Can a long path be an issue?
jaredpar
approved these changes
Nov 4, 2024
chsienki
approved these changes
Nov 4, 2024
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| <!-- Enable output of generated files back into our Generated directory --> | |||
| <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | |||
| <CompilerGeneratedFilesOutputPath>Generated</CompilerGeneratedFilesOutputPath> | |||
| <CompilerGeneratedFilesOutputPath>$(MSBuildThisFileDirectory)\Generated</CompilerGeneratedFilesOutputPath> | |||
There was a problem hiding this comment.
Yeah, I'm fine with leaving it as absolute as in the project file it means the same thing ultimately.
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #75680 until the fix flows into VS IntPreview.