Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix all for Use Auto Property #75788

Merged
merged 11 commits into from
Nov 7, 2024

Conversation

CyrusNajmabadi
Copy link
Member

We were previously using hte batch fixer here as a real fix all provider was complex and costly. However, the batch fixer does a terrible job with adjacent edits. Moved to a real fix all provider so we can make all the edits correctly.

Fixes #75634
Fixes #26527

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 6, 2024 19:06
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 6, 2024
@@ -77,23 +82,46 @@ public sealed override Task RegisterCodeFixesAsync(CodeFixContext context)
return Task.CompletedTask;
}

private async Task<Solution> ProcessResultAsync(CodeFixContext context, Diagnostic diagnostic, CancellationToken cancellationToken)
//private async Task<Solution> ProcessResultAsync(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yupyup

var locations = diagnostic.AdditionalLocations;

var propertyLocation = locations[0];
var declaratorLocation = locations[1];
//var propertyLocation = locations[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed?

@CyrusNajmabadi CyrusNajmabadi merged commit b9f7033 into dotnet:main Nov 7, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 7, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the useAutoPropFixAll branch November 8, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
2 participants